From 27d748e0f22fecd502d55cbf4ab7b5e3c1ec0738 Mon Sep 17 00:00:00 2001 From: Leaf Shi <132890443+LeafShi1@users.noreply.github.com> Date: Fri, 10 May 2024 16:36:18 +0000 Subject: [PATCH] Skip unstable tests in "ButtonTests", "ListViewTests" and "NumericUpDownTests" (#11330) * Skip unstable tests in "ButtonTests", "ListViewTests" and "NumericUpDownTests" * Add indent --- .../UIIntegrationTests/ButtonTests.cs | 12 ++++++++++++ .../UIIntegrationTests/ListViewTests.cs | 3 +++ .../UIIntegrationTests/NumericUpDownTests.cs | 3 +++ 3 files changed, 18 insertions(+) diff --git a/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ButtonTests.cs b/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ButtonTests.cs index 0973e0dfce8..dc1dc516f4e 100644 --- a/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ButtonTests.cs +++ b/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ButtonTests.cs @@ -51,7 +51,10 @@ await InputSimulator.SendAsync( }); } + [ActiveIssue("https://github.com/dotnet/winforms/issues/11324")] [WinFormsFact] + [SkipOnArchitecture(TestArchitectures.X64, + "Flaky tests, see: https://github.com/dotnet/winforms/issues/11324")] public async Task Button_DialogResult_SpaceToClickFocusedButtonAsync() { await RunTestAsync(async (form, button) => @@ -87,7 +90,10 @@ await InputSimulator.SendAsync( }); } + [ActiveIssue("https://github.com/dotnet/winforms/issues/11326")] [WinFormsFact] + [SkipOnArchitecture(TestArchitectures.X64, + "Flaky tests, see: https://github.com/dotnet/winforms/issues/11326")] public async Task Button_CancelButton_EscapeClicksCancelButtonAsync() { await RunTestAsync(async (form, button) => @@ -305,7 +311,10 @@ await InputSimulator.SendAsync( }); } + [ActiveIssue("https://github.com/dotnet/winforms/issues/11327")] [WinFormsFact] + [SkipOnArchitecture(TestArchitectures.X64, + "Flaky tests, see: https://github.com/dotnet/winforms/issues/11327")] public async Task Button_PerformClick_Fires_OnClickAsync() { await RunTestAsync((form, button) => @@ -341,7 +350,10 @@ await InputSimulator.SendAsync( }); } + [ActiveIssue("https://github.com/dotnet/winforms/issues/11325")] [WinFormsFact] + [SkipOnArchitecture(TestArchitectures.X64, + "Flaky tests, see: https://github.com/dotnet/winforms/issues/11325")] public async Task Button_Hotkey_Fires_OnClickAsync() { await RunTestAsync(async (form, button) => diff --git a/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ListViewTests.cs b/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ListViewTests.cs index 400345ca0de..a0af5722140 100644 --- a/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ListViewTests.cs +++ b/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ListViewTests.cs @@ -39,7 +39,10 @@ await InputSimulator.SendAsync( }); } + [ActiveIssue("https://github.com/dotnet/winforms/issues/11328")] [WinFormsFact] + [SkipOnArchitecture(TestArchitectures.X64, + "Flaky tests, see: https://github.com/dotnet/winforms/issues/11328")] public async Task ListView_Group_NavigateKeyboard_SucceedsAsync() { await RunTestAsync(async (form, listView) => diff --git a/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/NumericUpDownTests.cs b/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/NumericUpDownTests.cs index 13ef2c17678..7896f200889 100644 --- a/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/NumericUpDownTests.cs +++ b/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/NumericUpDownTests.cs @@ -12,7 +12,10 @@ public NumericUpDownTests(ITestOutputHelper testOutputHelper) { } + [ActiveIssue("https://github.com/dotnet/winforms/issues/11329")] [WinFormsFact] + [SkipOnArchitecture(TestArchitectures.X64, + "Flaky tests, see: https://github.com/dotnet/winforms/issues/11329")] public async Task NumericUpDownAccessibleObject_Focused_ReturnsCorrectValueAsync() { await RunSingleControlTestAsync(async (form, control) =>