Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4 support? #456

Open
Khalian opened this issue Sep 11, 2017 · 12 comments
Open

Swift 4 support? #456

Khalian opened this issue Sep 11, 2017 · 12 comments

Comments

@Khalian
Copy link
Collaborator

Khalian commented Sep 11, 2017

What would be the effort needed for a swift 4 upgrade/support? @goktugyil ? @lfarah ?

@lfarah lfarah mentioned this issue Sep 13, 2017
8 tasks
@Esqarrouth
Copy link
Owner

It seems 95% of the conversion process takes time but is trivial. The rest 5%, like some non-mainstream methods would take a lot of time to convert.

There is also no need to rush Swift 4 support for this version of the Swift. My project is Swift 4 but all my pods are Swift 3 and its working perfectly.

@Esqarrouth
Copy link
Owner

I could do this, but seems Lucas started it. It would be easier for single person to handle all conversion tasks except that possible weird 5%

@happiehappie
Copy link

Any updates on this? Just wondering

@Khalian
Copy link
Collaborator Author

Khalian commented Dec 24, 2017

@happiehappie @lfarah was working on this. If there is no response over the next week, I will schedule some time and finish the upgrade.

@hemangshah
Copy link

@Khalian, any updates on this?

@Khalian
Copy link
Collaborator Author

Khalian commented Jan 17, 2018

@hemangshah Hey sorry I did not get a chance to look at this. It seems @lfarah did not either. I will see if I can put in a few spare cycles over this weekend.

@ndemie
Copy link

ndemie commented Mar 14, 2018

@Khalian Any update?

@lfarah
Copy link
Collaborator

lfarah commented Mar 14, 2018

Just updated my PR, which is pending approval

@Marcello168
Copy link

any updates on this?

@Marcello168
Copy link

@Khalian any updates on this?

@relsirc
Copy link

relsirc commented May 10, 2018

I'm also wondering about this.

@Khalian
Copy link
Collaborator Author

Khalian commented May 10, 2018

This is the final PR : #476. @lfarah @goktugyil I need some eyes in this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants