Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation ??! #12

Open
sinamiandashti opened this issue Nov 2, 2012 · 4 comments
Open

Annotation ??! #12

sinamiandashti opened this issue Nov 2, 2012 · 4 comments

Comments

@sinamiandashti
Copy link

actually your module not works with classes that have annotation

because it doesn't minify the doc block above the variable ... just ignoring them

or your module does not support comments !

@EvanDotPro
Copy link
Owner

This is true -- we'd have to either figure out a way to omit files with annotations or include all comments or just comments we detect that are annotations. Omitting them would probably be the quickest solution.

@bacinsky
Copy link

I think comment annotations are just a shortcut for configuration, so (if any) annotations should be cached, like an ordinary config.php file. Preserving annotations is not good, because than PHP files can't be minified without comments.

@seyfer
Copy link

seyfer commented Mar 12, 2015

Doctrine doesn't work without annotations!

@lsklyut
Copy link

lsklyut commented Mar 15, 2015

@bacinsky I'm interested in what you mean by caching them like an ordinary config.php file - could you please elaborate?

EDIT: I forgot that the module does not cache non-Zend classes; @seyfer could you please elaborate on how Doctrine is broken by this module?

I think we could keep an array of known classes/namespaces which break this cache, and simply ignore them ( #21 and I believe #28 for Zend\Db )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants