diff --git a/README.md b/README.md index 4e78740d6a0..09a41fb37a2 100644 --- a/README.md +++ b/README.md @@ -64,7 +64,6 @@ For help using Mixxx, there are a variety of options: - [Mixxx manual][manual] - [Mixxx wiki][wiki] -- [Frequently Asked Questions][FAQ] - [Hardware Compatibility] - [Creating Skins] @@ -103,7 +102,6 @@ license. [blog]: https://mixxx.org/news/ [manual]: https://manual.mixxx.org/ [wiki]: https://github.com/mixxxdj/mixxx/wiki -[faq]: https://github.com/mixxxdj/mixxx/wiki/Faq [visualstudio2019]: https://docs.microsoft.com/visualstudio/install/install-visual-studio?view=vs-2019 [easybugs]: https://github.com/mixxxdj/mixxx/issues?q=is%3Aopen+is%3Aissue+label%3Aeasy [creating skins]: https://mixxx.org/wiki/doku.php/Creating-Skins diff --git a/res/controllers/Numark-Scratch-scripts.js b/res/controllers/Numark-Scratch-scripts.js index 3a29485ae9c..60605806900 100644 --- a/res/controllers/Numark-Scratch-scripts.js +++ b/res/controllers/Numark-Scratch-scripts.js @@ -3,36 +3,35 @@ var NumarkScratch = {}; /* * USER CONFIGURABLE SETTINGS. + * Change settings in the preferences */ // Defines the Beatloop Roll sizes for the 4 pads, for available values see: -// https://manual.mixxx.org/2.4/en/chapters/appendix/mixxx_controls.html#control-[ChannelN]-beatlooproll_X_activate +// https://manual.mixxx.org/latest/en/chapters/appendix/mixxx_controls.html#control-[ChannelN]-beatlooproll_X_activate // Default: [0.25, 0.5, 1, 2] NumarkScratch.autoLoopSizes = [ - "0.25", - "0.5", - "1", - "2", + engine.getSetting("beatLoopRollsSize1") || 0.25, + engine.getSetting("beatLoopRollsSize2") || 0.5, + engine.getSetting("beatLoopRollsSize3") || 1, + engine.getSetting("beatLoopRollsSize4") || 2, ]; // Defines how the Loop Encoder functions. // If 'true' the Encoder scrolls the library/loads track. Shift + Encoder manages looping. // If 'false' the Encoder manages looping. Shift + Encoder scrolls the library/loads track (Serato default). // Default: false -NumarkScratch.invertLoopEncoderFunction = false; +NumarkScratch.invertLoopEncoderFunction = !!engine.getSetting("invertLoopEncoderFunction"); -// Defines the bightness of button LEDs when they inactive. -// '0x00' sets the LEDSs to completely off. '0x01 sets the LEDs to dim. -// Default: 0x01 (dim) -NumarkScratch.LOW_LIGHT = 0x01; +// Define whether or not to keep LEDs dimmed if they are inactive. +// 0x01 ('true' in UI) will keep them dimmed, 0x00 ('false' in UI) will turn them off. Default: 0x01 ('true') +NumarkScratch.noLight = 0x00; +NumarkScratch.dimLight = 0x01; +components.Button.prototype.off = engine.getSetting("inactiveLightsAlwaysBacklit") ? NumarkScratch.dimLight : NumarkScratch.noLight; /* * CODE */ - -components.Button.prototype.off = NumarkScratch.LOW_LIGHT; - NumarkScratch.init = function() { // Initialize component containers NumarkScratch.deck = new components.ComponentContainer(); diff --git a/res/controllers/Numark-Scratch.midi.xml b/res/controllers/Numark-Scratch.midi.xml index d550bf831a3..a23674152c1 100644 --- a/res/controllers/Numark-Scratch.midi.xml +++ b/res/controllers/Numark-Scratch.midi.xml @@ -1,12 +1,102 @@ - + Numark Scratch Al Hadebe(NotYourAverageAl) Mapping for the Numark Scratch Mixer - NumarkScratch - NumarkScratch + https://mixxx.discourse.group/t/numark-scratch-mapping/25186 + https://manual.mixxx.org/latest/en/hardware/controllers/numark_scratch + + + + + + + + + + + + + + + + diff --git a/res/controllers/midi-components-0.0.js b/res/controllers/midi-components-0.0.js index 30518aac633..225e5c6e083 100644 --- a/res/controllers/midi-components-0.0.js +++ b/res/controllers/midi-components-0.0.js @@ -481,8 +481,7 @@ if (this.max === Component.prototype.max) { this.max = (1 << 14) - 1; } - value = (value << 7) + (this._firstLSB ? this._firstLSB : 0); - this.input(channel, control, value, status, group); + this.input(channel, control, (value << 7) + (this._firstLSB ? this._firstLSB : 0), status, group); } this.MSB = value; }, diff --git a/src/library/tabledelegates/multilineeditdelegate.cpp b/src/library/tabledelegates/multilineeditdelegate.cpp index 3dd6904fc8d..6a0e347a1ea 100644 --- a/src/library/tabledelegates/multilineeditdelegate.cpp +++ b/src/library/tabledelegates/multilineeditdelegate.cpp @@ -32,6 +32,11 @@ MultiLineEditor::MultiLineEditor(QWidget* pParent, // Add event filter to catch right-clicks and key presses, see eventFilter() installEventFilter(this); + // Explicitly set the font, otherwise the font might be reset + // after first edit. + const auto font = m_pTableView->font(); + setFont(font); + // Adjust size to fit content and maybe shift vertically to fit into the // library view. documentSizeChanged() is emitted when the layout has been // adjusted according to text changes, incl. initial fill.