From 4266708f17238845c183449a49c49c3838f3d67b Mon Sep 17 00:00:00 2001
From: Jay Chia <jaychia94@gmail.com@users.noreply.github.com>
Date: Tue, 10 Dec 2024 18:49:00 +0800
Subject: [PATCH] Upload logs even if job submission fails

---
 .github/workflows/run-cluster.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.github/workflows/run-cluster.yaml b/.github/workflows/run-cluster.yaml
index 644250d1f1..214e9d879b 100644
--- a/.github/workflows/run-cluster.yaml
+++ b/.github/workflows/run-cluster.yaml
@@ -123,6 +123,7 @@ jobs:
           --runtime-env-json "$ray_env_var" \
           -- python ${{ inputs.entrypoint_script }} ${{ inputs.entrypoint_args }}
     - name: Download log files from ray cluster
+      if: always()
       run: |
         source .venv/bin/activate
         ray rsync-down .github/assets/ray.yaml /tmp/ray/session_*/logs ray-daft-logs
@@ -152,6 +153,7 @@ jobs:
         source .venv/bin/activate
         ray down .github/assets/ray.yaml -y
     - name: Upload log files
+      if: always()
       uses: actions/upload-artifact@v4
       with:
         name: ray-daft-logs