Fixes daft-connect table replacement

Author: rchowell

src/daft-connect/src/execute.rs

@@ -234,16 +234,13 @@ impl ConnectSession {
                 )
             })?;
 
-        {
-            // TODO session should handle the pre-existence error
-            if !replace && self.session().has_table(&name.clone().into()) {
-                return Err(Status::internal("Dataframe view already exists"));
-            }
+        let session = self.session_mut();
+
+        if replace {
+            _ = session.detach_table(&name);
         }
 
-        let session = self.session_mut();
         let view = View::from(input.build()).arced();
-
         session.attach_table(view, name).map_err(|e| {
             Status::internal(textwrap::wrap(&format!("Error in Daft server: {e}"), 120).join("\n"))
         })?;

src/daft-sql/src/python.rs

@@ -34,7 +34,6 @@ impl SQLFunctionStub {
     }
 }
 
-// TODO replace with session.exec to invert responsibilities
 #[pyfunction]
 pub fn sql(
     sql: &str,

tests/connect/test_basics.py

@@ -241,6 +241,8 @@ def test_show(spark_session, capsys):
         "│ 9     │\n"
         "╰───────╯\n"
     )
+    # This may fail locally depending on your terminal and how you run the test.
+    # The show() command uses ANSI escape sequences to make the header bold.
     assert captured.out == expected