Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move daft.daft.spark_connect into a dedicated module #3497

Closed
universalmind303 opened this issue Dec 5, 2024 · 0 comments
Closed

move daft.daft.spark_connect into a dedicated module #3497

universalmind303 opened this issue Dec 5, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers needs triage

Comments

@universalmind303
Copy link
Contributor

universalmind303 commented Dec 5, 2024

Is your feature request related to a problem?

currently the spark_connect function is exported directly from our "private" daft.daft module. This should instead be reexported through a dedicated module.

Describe the solution you'd like

instead of

from daft.daft import spark_connect

we should instead do something like this:

from daft.spark import spark_connect

Describe alternatives you've considered

No response

Additional Context

No response

Would you like to implement a fix?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers needs triage
Projects
None yet
Development

No branches or pull requests

1 participant