Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: unify daft.catalog and daft.sql.catalog #3586

Closed
universalmind303 opened this issue Dec 16, 2024 · 0 comments · Fixed by #3696
Closed

sql: unify daft.catalog and daft.sql.catalog #3586

universalmind303 opened this issue Dec 16, 2024 · 0 comments · Fixed by #3696
Labels
sql

Comments

@universalmind303
Copy link
Contributor

universalmind303 commented Dec 16, 2024 •
edited
Loading

WRT to the catalogs, @universalmind303 what do you think of starting to unify around the DaftMetaCatalog that I introduced in #3036?

I think we have a few competing standards atm (including the SQLCatalog). It could be good to start having a catalog abstraction that can be shared across our different frontends

yes, that is something I want to do and have been thinking about. I'll open up an issue to unify daft.catalog and daft.sql.catalog

Originally posted by @universalmind303 in #3581 (comment)
@universalmind303 universalmind303 changed the title unify daft.catalog and daft.sql.catalog sql: unify daft.catalog and daft.sql.catalog Dec 16, 2024
@universalmind303 universalmind303 mentioned this issue Jan 16, 2025
Merged
universalmind303 added a commit that referenced this issue Jan 17, 2025
@universalmind303
feat(connect): sql (#3696)
6b302af 
## Description
adds spark's `df.createOrReplaceTempView` and `spark.sql` to enable sql
workflows.

ex:

```py
my_table = spark.read.parquet('my_table.parquet')
my_tablecreateOrReplaceTempView('my_table')

spark.sql('select * from my_table')
```

### Note for reviewers:

in order for it to be easier to interop with connect, I removed the
`SQLCatalog` and refactored the `SQLPlanner` to take in a
`DaftMetaCatalog` instead. This partially closes
#3586. I think we still need
to do some work on the python side of things though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sql
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(connect): sql universalmind303/Daft
1 participant
@universalmind303