-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guid support #396
Comments
I am a bit confused, where do you want to support GUID? |
probably on Mongo projections that require by default a string Id. |
Yeah but Mongo projections work just fine 🤷♂️. I kind of get a gist of it that maybe the thought is to use GUID instead of typed identity. Eventuous used to use strings for that purpose. The issue is that it weakens the type system. Or, maybe, the idea is to use GUID as the identity value, but it is limiting because a GUID can be converted to a string but not every string can be converted to a GUID. And, identity could be anything. Like, hashed email or ip address. |
Hi. I don't usually comment on GH so forgive me if i am not clear. Recap current situation as i see it:The
and constructor uses string without other overrides
My caseI use .NET But for this to work i created this monstrosity
so i can use it for the state as My questionGiven that GUIDs are popular and supported in .NET and Postgresql (both of which are supported my Eventuous), would you consider adding Or can we (i can try, too) add a section in docs hinting how to use GUIDs. |
Just have a base record that uses |
Is your feature request related to a problem? Please describe.
Hi. I would like to use Guid and quick search over the issues for a word "guid" showed at least two issues where people mention their own wrappers for guid.
I may be exaggerating but guid (v7 in particular) is a pretty common/popular these days. Don't take my word for it, i don't have the evidence.
While listening to to some of A.Zimarev presentations in Youtube, i may overheard that he is not interested in guid (again, with all due respect, i don't have evidence and i dont want to listen those hours of talk for something that perhaps was not even said).
Describe the solution you'd like
I know people here have their wrappers for guid->string->guid conversion. I have one too. If there is a popular demand and conceptual approve from the Eventuous leadership, i may contribute mine and then we talk.
Describe alternatives you've considered
_ => new CarId(Guid.NewGuid().ToString())
Additional context
I recently discovered Eventuous. Love it.
The text was updated successfully, but these errors were encountered: