You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the install command checks to see if the binary exists, and if it does, immediately resolves the promise without taking any actions.
This is fine for first time installs, but will cause unintended behaviors if users of the wrapper npm module are updating their dependencies. The npm i of the wrapping module will succeed, and users will be unaware that the functionality behind the module remained on an old version.
Suggestion here would be to add an option to the install function enabling it to overwrite the existing file. Calling modules could then have their own logic to determine when to use the overwrite option for install.
I am willing to contribute this feature.
The text was updated successfully, but these errors were encountered:
Moving an issue from apollographql/rover#1563 to here.
Currently the install command checks to see if the binary exists, and if it does, immediately resolves the promise without taking any actions.
This is fine for first time installs, but will cause unintended behaviors if users of the wrapper npm module are updating their dependencies. The
npm i
of the wrapping module will succeed, and users will be unaware that the functionality behind the module remained on an old version.Suggestion here would be to add an option to the
install
function enabling it to overwrite the existing file. Calling modules could then have their own logic to determine when to use the overwrite option forinstall
.I am willing to contribute this feature.
The text was updated successfully, but these errors were encountered: