Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a npm package will not cause an updated binary to install #43

Open
LongLiveCHIEF opened this issue Feb 13, 2024 · 0 comments
Open

Comments

@LongLiveCHIEF
Copy link

Moving an issue from apollographql/rover#1563 to here.

Currently the install command checks to see if the binary exists, and if it does, immediately resolves the promise without taking any actions.

This is fine for first time installs, but will cause unintended behaviors if users of the wrapper npm module are updating their dependencies. The npm i of the wrapping module will succeed, and users will be unaware that the functionality behind the module remained on an old version.

Suggestion here would be to add an option to the install function enabling it to overwrite the existing file. Calling modules could then have their own logic to determine when to use the overwrite option for install.

I am willing to contribute this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant