Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to read on a NoneType. #28

Open
bryanhelmig opened this issue Mar 11, 2014 · 6 comments
Open

Trying to read on a NoneType. #28

bryanhelmig opened this issue Mar 11, 2014 · 6 comments

Comments

@bryanhelmig
Copy link

Traceback (most recent call last):
..... removed application code traceback ....
File "/home/ubuntu/.virtualenvs/zapier/local/lib/python2.7/site-packages/evernote/edam/notestore/NoteStore.py", line 4576, in getNoteTagNames
return self.recv_getNoteTagNames()
File "/home/ubuntu/.virtualenvs/zapier/local/lib/python2.7/site-packages/evernote/edam/notestore/NoteStore.py", line 4588, in recv_getNoteTagNames
(fname, mtype, rseqid) = self._iprot.readMessageBegin()
File "/home/ubuntu/.virtualenvs/zapier/local/lib/python2.7/site-packages/thrift/protocol/TBinaryProtocol.py", line 126, in readMessageBegin
sz = self.readI32()
File "/home/ubuntu/.virtualenvs/zapier/local/lib/python2.7/site-packages/thrift/protocol/TBinaryProtocol.py", line 203, in readI32
buff = self.trans.readAll(4)
File "/home/ubuntu/.virtualenvs/zapier/local/lib/python2.7/site-packages/thrift/transport/TTransport.py", line 58, in readAll
chunk = self.read(sz-have)
File "/home/ubuntu/.virtualenvs/zapier/local/lib/python2.7/site-packages/thrift/transport/THttpClient.py", line 116, in read
return self.__http.file.read(sz)
AttributeError: 'NoneType' object has no attribute 'read'

We are using 1.25.0.

One guess from the affected was that the note was missing content and the library wasn't handling that case.

@rekotan
Copy link
Contributor

rekotan commented Mar 18, 2014

Could you provide code snippet to see if I could reproduce it?

@bryanhelmig
Copy link
Author

It happened via a normal getNoteTagNames call (which works 99.9% of the time) but it was just one user with the bug.

@nopivnick
Copy link

it was just one user with the bug

that would be me.

I'm guessing I may be something of an edge case given how I (ab)use
Evernote.

if I can be of any help in investigating things, please let me know.

noah

Noah Pivnick
+1 (917) 579-0534
http://about.me/nopivnick

On Tue, Mar 18, 2014 at 2:16 PM, Bryan Helmig [email protected]:

It happened via a normal getNoteTagNames call (which works 99.9% of the
time) but it was just one user with the bug.


Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-37968586
.

@rekotan
Copy link
Contributor

rekotan commented Mar 18, 2014

I tested this quick and it works fine even though the note has no tags. Empty content shouldn't affect getNoteTagNames and I can't imagine there could be any edge case for getNoteTagNames since it's just too simple API. It would be helpful if you could find a way to reproduce this.

@bryanhelmig
Copy link
Author

@nopivnick Would it be okay if I tried to wrap up a full test case with your auth credentials and send them privately to @rekotan over email?

@nopivnick
Copy link

have at it, @bryanhelmig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants