Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up sparse matrix construction functions used in solver constrctor #308

Open
ddement opened this issue Nov 19, 2024 · 0 comments
Open
Assignees
Labels
code-efficiency Related to making code more efficient code-quality Tasks such as code formatting improvements, style guideline adherence, refactoring etc.

Comments

@ddement
Copy link
Collaborator

ddement commented Nov 19, 2024

Task: Improve the code quality of the solver constructor code by performing the sparse matrix creation in parallel kernels on the GPU. Also, add unit tests for the newly created functions which build our sparse matrices using the freedom map data structures.

Why: This step will improve unit test code coverage and hopefully improve the performance of solver construction (although this is not anticipated to be a bottleneck).

Done means: the K, T, B, and B_t matrices are constructed on GPU. Unit tests are written for their new constructors. The old kernels for constructing these structures are deleted.

@ddement ddement added code-quality Tasks such as code formatting improvements, style guideline adherence, refactoring etc. code-efficiency Related to making code more efficient labels Nov 19, 2024
@ddement ddement self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-efficiency Related to making code more efficient code-quality Tasks such as code formatting improvements, style guideline adherence, refactoring etc.
Projects
None yet
Development

No branches or pull requests

1 participant