Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some superfluous variables #194

Open
sit23 opened this issue Nov 24, 2020 · 0 comments
Open

Remove some superfluous variables #194

sit23 opened this issue Nov 24, 2020 · 0 comments
Labels
core Core modules of Isca (including time managers) priority:low Low-priority task

Comments

@sit23
Copy link
Contributor

sit23 commented Nov 24, 2020

Description

There are some variables in the model code that seem to be completely unused. For example, the variable pstd in constants.F90 is the reference pressure in dynes/cm2, is a namelist parameter, and does not appear to be used anywhere in the code. It would be good if this variable could be removed entirely to avoid confusion. This issue is then more of a reminder for us to look at this, and to try removing pstd to check if it is indeed superfluous. There may well be several other superfluous variables like this, so it would be good to check for others.

@sit23 sit23 added core Core modules of Isca (including time managers) priority:low Low-priority task labels Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core modules of Isca (including time managers) priority:low Low-priority task
Projects
None yet
Development

No branches or pull requests

1 participant