remove some ostringstreams #3157
Draft
+44
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmilos
reviewed
Feb 9, 2025
There was a problem hiding this comment.
I think there was one more instance towards the bottom of this file?
There was a problem hiding this comment.
Not sure what you mean.
There was a problem hiding this comment.
Line 338 in a5899b6
neheb
force-pushed
the
un
branch
3 times, most recently
from
d941fa9 to
e08998e
Compare
Looks like they're slow under Cygwin. Signed-off-by: Rosen Penev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like they're slow under Cygwin.
Maybe fixes #3153