Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zilliqa schnorr signing (again) #189

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

feri42
Copy link
Contributor

@feri42 feri42 commented Dec 6, 2024

Cherry picked #185 from master, to be released without the post 7.4 upgrades.

@feri42 feri42 self-assigned this Dec 6, 2024
@feri42 feri42 changed the title feat: add zilliqa schnorr signing (#185) feat: add zilliqa schnorr signing (again) Dec 6, 2024
@feri42 feri42 merged commit d9746b5 into keychain-7.4.x Dec 6, 2024
6 checks passed
@feri42 feri42 deleted the f/zilliqa-signing branch December 6, 2024 17:50
@feri42
Copy link
Contributor Author

feri42 commented Dec 6, 2024

How can I release a version of keychain from the [keychain-7.4.x](https://github.com/ExodusMovement/exodus-oss/tree/keychain-7.4.x) branch?

@kewde
Copy link
Contributor

kewde commented Dec 6, 2024

@feri42 try manually releasing it

yarn
cd features/keychain
npm publish

@feri42
Copy link
Contributor Author

feri42 commented Dec 9, 2024

@feri42 try manually releasing it

Doesn't work out-of-the-box:

npm error code E404
npm error 404 Not Found - PUT https://registry.npmjs.org/@exodus%2fkeychain - Not found
npm error 404
npm error 404  '@exodus/[email protected]' is not in this registry.

feri42 added a commit that referenced this pull request Dec 9, 2024
@sparten11740
Copy link
Contributor

@mvayngrib you are admin in this repo right? could you protect the branch keychain-7.4.x with the default ruleset, so we can publish from it?

@feri42
Copy link
Contributor Author

feri42 commented Dec 9, 2024

I switched to the existing @exodus/keychain-7.4 branch. And was able to publish 7.4.3 using the github 'Publish' workflow.

@feri42
Copy link
Contributor Author

feri42 commented Dec 9, 2024

Also, I've deleted keychain-7.4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants