Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update hms metrics namespace #288

Merged
merged 28 commits into from
Nov 20, 2024
Merged

feat: update hms metrics namespace #288

merged 28 commits into from
Nov 20, 2024

Conversation

DhrubajyotiSadhu
Copy link
Contributor

@DhrubajyotiSadhu DhrubajyotiSadhu commented Nov 12, 2024 •
edited
Loading

📝 Description: For common dashboards, we need to have common namespaces.

Changed

  • Updated the hms namespaces for metrics for both readwrite and readonly.

Added

  • Added following variables:
    • hms_ecs_metrics_readwrite_namespace
    • hms_ecs_metrics_readonly_namespace
    • hms_k8s_metrics_readwrite_namespace
    • hms_k8s_metrics_readonly_namespace

🔗 Related Issues

@DhrubajyotiSadhu DhrubajyotiSadhu requested a review from a team as a code owner November 12, 2024 13:11
patduin
patduin reviewed Nov 12, 2024
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
patduin
patduin reviewed Nov 12, 2024
View reviewed changes
variables.tf Show resolved Hide resolved
githubjianli
githubjianli reviewed Nov 12, 2024
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
mollonado
mollonado reviewed Nov 13, 2024
View reviewed changes
common.tf Outdated Show resolved Hide resolved
@githubjianli githubjianli changed the title Feature/common dashboards feat: update hms metrics namespace Nov 19, 2024
@githubjianli
Copy link
Collaborator

test plan: https://rundeck-ha.test.aws.away.black/project/Terraform/execution/show/79086#output

This was referenced Nov 20, 2024
Closed
Closed
patduin
patduin reviewed Nov 20, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
patduin
patduin reviewed Nov 20, 2024
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
patduin
patduin reviewed Nov 20, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@DhrubajyotiSadhu DhrubajyotiSadhu merged commit f73c42a into master Nov 20, 2024
2 checks passed
@DhrubajyotiSadhu DhrubajyotiSadhu deleted the feature/common_dashboards branch November 20, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamzaJugon HamzaJugon HamzaJugon approved these changes

@patduin patduin patduin approved these changes

@githubjianli githubjianli Awaiting requested review from githubjianli

@mollonado mollonado Awaiting requested review from mollonado

@jmnunezizu jmnunezizu Awaiting requested review from jmnunezizu

@mroark1m mroark1m Awaiting requested review from mroark1m

@JayGreeeen JayGreeeen Awaiting requested review from JayGreeeen

@javsanbel2 javsanbel2 Awaiting requested review from javsanbel2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DhrubajyotiSadhu @githubjianli @patduin @mollonado @HamzaJugon @JianLi-Expedia