[$1000] [mweb-Android] click on back button of device navigates to payments page instead of setting page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to settings> payments
2. click on add payment method button
3. select bank account option
4. click on ✖️ button (this should bring you back to the payments page)
5. press the physical back button of device (this should bring you back to the settings page)

Note on step 5: if you click the the back caret icon, the app will navigate back to the settings page as expected. To reproduce this behavior, you need to make sure you are clicking the physical back button on the device.

Expected Result:

should navigate to settings page

Actual Result:

navigates to payments page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• [x ] Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230608_000513_Chrome_1.mp4

az_recorder_20230613_103406.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686163312643879

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017cf84038380781c3
• Upwork Job ID: 1671163486872637440
• Last Price Increase: 2023-07-11

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[c3024]

The previous page is payments page. Why should it go to settings page?

[johncschuster]

I don't think that's correct, @c3024. After clicking 'X' on the Plaid popup, you should be back on the payments page. Clicking back should bring you to the previous page, which should be the settings page.

I've updated the repro steps to make that a bit clearer.

[melvin-bot]

@johncschuster Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017cf84038380781c3

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[johncschuster]

Calm down, Melvin. I just triaged the issue.

[hoangzinh]

I don't think that's correct, @c3024. After clicking 'X' on the Plaid popup, you should be back on the payments page. Clicking back should bring you to the previous page, which should be the settings page.

I've updated the repro steps to make that a bit clearer.

yeah, but in this case, it's a close/cancel button. So clicking 'X' on the Plaid popup, I think we should be back on the payments page so user can select other payment options

[johncschuster]

@hoangzinh I get where you're coming from, but I think the 'X' would simply close the modal, which should bring us back to the last thing we saw before the modal, right?

Your suggestion is more like a redirect, isn't it?

[hoangzinh]

sorry @johncschuster I think I didn't all steps to reproduce this issue carefully. Originally I thought when we click "X" we would like to navigate back to Setting page.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[johncschuster]

@eVoloshchak can you take a look at the above proposal when you get a moment?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@johncschuster @eVoloshchak this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[johncschuster]

Looks like we're still waiting on proposals for this one.

[johncschuster]

Thanks @srikarparsi!

[srikarparsi]

check up: https://expensify.slack.com/archives/CCQJP89RV/p1691000228916339?thread_ts=1689928793.556129&cid=CCQJP89RV. Said they'll have an update by the end of the week.

[johncschuster]

Awesome. Thanks for the update!

[srikarparsi]

They said a fix should be in place but it doesn't seem to be. Sent a message following up: https://expensify.slack.com/archives/CCQJP89RV/p1691084404394809?thread_ts=1689928793.556129&cid=CCQJP89RV

[srikarparsi]

The fix has been deployed and it works. If there are no payments to be made, this issue should be good to close out @johncschuster
https://github.com/Expensify/App/assets/48188732/d0d69021-a7ff-4e43-a5b4-57fb96ba137d

[srikarparsi]

Hey @johncschuster! Just wanted to bump this

[srikarparsi]

Sorry, John is OOO, couldn't find when he's back on the calendar but will reassign on Wednesday if he isn't back.

[johncschuster]

Hey hey! I think my status in NewDot was incorrect – I'm not OOO. I'm catching up now!

[srikarparsi]

Hey @johncschuster! Just wanted to bump this for payment :)

[melvin-bot]

@johncschuster, @eVoloshchak, @srikarparsi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[srikarparsi]

Hey @johncschuster! Bump on the above.

[johncschuster]

Derp! I'm sorry for missing this! Catching up now.

[johncschuster]

Ok! It looks like this is good to close out. Closing!

[gadhiyamanan]

Payment is pending here
cc: @johncschuster @srikarparsi

[johncschuster]

Payment has been issued! (Thanks for the callout, @mananjadhav!)