-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android - Group - Start group button on confirmation page has extra bottom margin #53190
Comments
Triggered auto assignment to @MariaHCD ( |
Triggered auto assignment to @twisterdotcom ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Seems like there are a few deploy blockers related to the way buttons appear in Android. Clarifying in the issue linked above ^ |
Should we close this or HOLD on #53161 (comment)? |
Assigning @kirillzyusko since this also looks to be a regression from the edge-to-edge PR |
@kirillzyusko could you comment here so I can assign you? |
Sure, feel free to assign me on this issue 👋 |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Can we assign @chrispader on this? He is working on this ticket at the moment |
commenting for assignment! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
Start group button on confirmation page will not have extra bottom margin
Actual Result:
Start group button on confirmation page has extra bottom margin.
This issue is not reproducible if device navigation uses swipe gestures.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6677725_1732691351761.Screen_Recording_20241127_150606.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: