-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-11] [HOLD App#53192] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step #53217
Comments
Triggered auto assignment to @stitesExpensify ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Similar to other android issues with the margin now after enabling the edge-to-edge feature cc @chrispader @kirillzyusko |
Yes, looks like safe area padding is missing on Android |
Triggered auto assignment to @muttmuure ( |
@kirillzyusko i will put this on hold for the other issue |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.70-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-11. 🎊 For reference, here are some details about the assignees on this issue:
|
@c3024 @muttmuure @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Payment Summary
BugZero Checklist (@muttmuure)
|
@c3024 - $250 C+ |
@mountiny, @muttmuure, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I did not review the PR referred in this issue. No payment is due for me here. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5268041
Issue reported by: Applause - Internal Team
Action Performed:
Preconditions
User logged in with an expensifail account.
User is an admin of a workspace and has enabled Expensify Cards in more features.
Workflows MUST be disabled in the workspace.
User has set a fully verified VBA before.
Steps
Expected Result:
The Next button in the "Select a Limit Type" step should be displayed above the navigation bar
Actual Result:
The navigation bar overlaps the Next button in the "Choose a limit type" step
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6677640_1732677257872.Next_button.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @muttmuureThe text was updated successfully, but these errors were encountered: