Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-11] [HOLD App#53192] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step #53217

Closed
1 of 8 tasks
lanitochka17 opened this issue Nov 27, 2024 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5268041
Issue reported by: Applause - Internal Team

Action Performed:

Preconditions
User logged in with an expensifail account.
User is an admin of a workspace and has enabled Expensify Cards in more features.
Workflows MUST be disabled in the workspace.
User has set a fully verified VBA before.
Steps

  1. Add another member to the WS so there's at least 2 members
  2. Navigate to the "Expensify Card" page in WS settings
  3. Tap on "Issue new card"
  4. Select the user you are using
  5. Select Virtual Card

Expected Result:

The Next button in the "Select a Limit Type" step should be displayed above the navigation bar

Actual Result:

The navigation bar overlaps the Next button in the "Choose a limit type" step

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6677640_1732677257872.Next_button.mp4

Bug6677640_1732677257890!Next_button (1)

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @muttmuure
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 27, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny
Copy link
Contributor

Similar to other android issues with the margin now after enabling the edge-to-edge feature cc @chrispader @kirillzyusko

@kirillzyusko
Copy link
Contributor

Yes, looks like safe area padding is missing on Android

@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 27, 2024
@mountiny mountiny moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor

@kirillzyusko i will put this on hold for the other issue

@mountiny mountiny changed the title Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step [HOLD] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step Nov 27, 2024
@mountiny mountiny changed the title [HOLD] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step [HOLD App#53192] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step Nov 27, 2024
@mountiny mountiny added the Reviewing Has a PR in review label Nov 29, 2024
Copy link

melvin-bot bot commented Dec 1, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 Weekly KSv2 labels Dec 3, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Dec 4, 2024
@melvin-bot melvin-bot bot changed the title [HOLD App#53192] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step [HOLD for payment 2024-12-11] [HOLD App#53192] Expensify Card - Navigation bar overlaps the Next button in Choose a limit type step Dec 4, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.70-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-11. 🎊

For reference, here are some details about the assignees on this issue:

  • @c3024 requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Dec 4, 2024

@c3024 @muttmuure @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 10, 2024
@garrettmknight garrettmknight moved this from Bugs and Follow Up Issues to Hold for Payment in [#whatsnext] #expense Dec 10, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

Payment Summary

Upwork Job

  • Reviewer: @c3024 owed $250 via NewDot

BugZero Checklist (@muttmuure)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2024
@muttmuure
Copy link
Contributor

@c3024 - $250 C+

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 12, 2024
Copy link

melvin-bot bot commented Dec 16, 2024

@mountiny, @muttmuure, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@c3024
Copy link
Contributor

c3024 commented Dec 16, 2024

I did not review the PR referred in this issue. No payment is due for me here.

@melvin-bot melvin-bot bot removed the Overdue label Dec 17, 2024
@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Status: Done
Development

No branches or pull requests

6 participants