[Due for payment 2025-02-26] [$50] Flaky tests/ui/GroupChatNameTests.tsx test

[mountiny]

Problem

The tests/ui/GroupChatNameTests.tsx test https://github.com/Expensify/App/actions/runs/13051191486/job/36411651957 is now failing in main and its not clear what is causing it, lets investigate and fix it.

EDIT: This is also affecting the test below ("Should show last message preview in LHN"): https://github.com/Expensify/App/actions/runs/13051191486/job/36411651957

This test seems to be flaky as it is passign after restart here https://github.com/Expensify/App/actions/runs/13050631537

Solution

Identify the offending PR that made if flaky - the test has been around for 6 months so something had to make it flaky recently

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884927641362998630
• Upwork Job ID: 1884927641362998630
• Last Price Increase: 2025-02-19

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884927641362998630

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Upwork job price has been updated to $50

[mountiny]

@rezkiy37 can you check, this first time happened after your PR https://github.com/Expensify/App/pull/54958/files

[rezkiy37]

@mountiny, the issue has been solved by re-runing - #56051 (comment).

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[rezkiy37]

I am testing it locally. Currently, it always works properly on the latest main for me.

[rezkiy37]

Workin with those fails: https://github.com/Expensify/App/actions/runs/13050631537/job/36409895953, https://github.com/Expensify/App/actions/runs/13051191486/job/36411651957.

[ikevin127]

I was only able to reproduce this the very first time I ran the test locally, specifically targeted only on the tests/ui/GroupChatNameTests.tsx file and it failed due to timeout (50000 ms):

After the very first time I wasn't able to reproduce anymore 🤷‍♂

[Dylanb-dev]

I can't reproduce on local

First time the error occurred in logs https://github.com/Expensify/App/actions/runs/13039925713
from PR #54163

Maybe it was the package update that changed it? suggest trying to reproduce with old package version

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sakluger, @mountiny, @fedirjh 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[pasyukevich]

@mountiny
It looks like it is failing again- https://github.com/Expensify/App/actions/runs/13180202083/job/36806035525?pr=56461

So, it is reproducible

Could you share more details about the env settings for the CI? (especially that specific for this flow)

[pasyukevich]

@mountiny bump here

[rezkiy37]

We just talked about it. We faced a few strange moments:

1. It runs on Ubuntu and it is specified as latest. Probably, it fails after some upgrade.
2. We don't know machine limitations and specifications. I mean RAM, CPU, other info. We are going to emulate it locally but we need more information.
3. Timelines. The project expects to run for 50 seconds but takes much more on CI.

Details

cc @mountiny

[melvin-bot]

@sakluger, @mountiny, @fedirjh 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

@sakluger @mountiny @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@sakluger, @mountiny, @fedirjh 12 days overdue now... This issue's end is nigh!

[rezkiy37]

Just a friendly reminder here #56057 (comment).

[rezkiy37]

We've found one more possible root cause of the problem. We compared commands that we launch locally and CI does remotely.

1. Local - npm run test - TZ=utc NODE_OPTIONS=--experimental-vm-modules jest.
2. Remote - NODE_OPTIONS="$NODE_OPTIONS --experimental-vm-modules" npx jest --silent --shard=3/3 --max-workers 4.

As you can see they are slightly different. CI uses a couple of parameters for jest. We've tried to add them locally and it works well. However, we faced a crucial discrepancy - npm vs npx. I could reproduce the bug once I ran the remote command locally.

Details

[pasyukevich]

I will update the PR with a CI patch to npm to test it remotely

Do we have any specific reasons for using npx?

[pasyukevich]

I've updated the workflow - not failed now

#56461

[rezkiy37]

I’m planning a short vacation next week from Monday to Wednesday, from the 17th to the 19th. I am working on the issue later.

[mountiny]

Sorry had been ooo last week

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.0-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Enable group chat name tests by removing skip from last message preview #56461

If no regressions arise, payment will be issued on 2025-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment through NewDot Manual Requests

[melvin-bot]

@fedirjh @sakluger @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mountiny]

No payments or regression tests required