-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] iOS - mWeb - Onboarding - The keyboard doesn't open when the name field is focus #57818
Comments
Triggered auto assignment to @maddylewis ( |
Job added to Upwork: https://www.upwork.com/jobs/~021897299810768522727 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
Couldn't reproduce without deactivating the keyboard on an iPhone 16 Simulator (Safari). Does it only happen on iPhone 12? |
Hello @LorenzoBloedow i can reproduce issue using iPhone 14 (mWeb/safari and mWeb/chrome) ScreenRecording_03-05-2025.22-33-16_1.MP4 |
if the bug is reproducible on iPhone 14, then yeah, i think we should still try to fix this one. |
🚨 Edited by proposal-police: This proposal was edited at 2025-03-09 10:09:40 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.The keyboard doesn't open when the TextInput is focused.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?For iOS mWeb (Chrome & Safari), we can use a simplified logic that runs For example, add the following code to the top of the useEffect of the if (isMobileWebKit()) {
inputRef.current?.focus();
return;
}
// existing logics What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A What alternative solutions did you explore? (Optional)I tried to use the |
ProposalPlease re-state the problem that we are trying to solve in this issue.The input is focused but the keyboard doesn't show. What is the root cause of that problem?This is a common issue on mWeb Safari where it happens if we delay the focus. In our case, we use
This happens on other pages too, for example, we have #58040. What changes do you think we should make in order to solve the problem?The focus delay was added to fix some issues on other platforms, such as Android and iOS. If we want to be safe, we can add a new param to If the delay focus param is false, then we don't need the timeout and interaction manager. App/src/hooks/useAutoFocusInput.ts Lines 24 to 54 in add7b6e
In money request participants page, the input also has a focus delay by default, so we can use If we want to apply the solution globally, then we can ignore the focus delay if the platform is mobile safari browser in For example, in App/src/components/SelectionList/BaseSelectionList.tsx Lines 683 to 689 in add7b6e
The risk of applying the solution globally is that it could creat this kind of issue, but when that happens (or other issues) we can fix it in a follow-up. What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A |
ProposalChanges:
|
@fedirjh - lmk your thoughts on the above proposals - thanks! |
@fedirjh Eep! 4 days overdue now. Issues have feelings too... |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.1.9-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 12 / Chrome
App Component: User Settings
Action Performed:
Expected Result:
The keyboard should open the name field is in focus
Actual Result:
The name field is focused but the keyboard doesn't open on the name field of the onboarding modal.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6761483_1741149453042.Keyboard_dont_open.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @fedirjhThe text was updated successfully, but these errors were encountered: