From 744a8c5a3daa8185e0762939a49b65f5ffea88cd Mon Sep 17 00:00:00 2001 From: Rory Abraham Date: Fri, 5 Nov 2021 10:28:34 -0700 Subject: [PATCH 1/2] Enable react/destructuring-assignment rule to ban destructuring of props or state --- rules/react.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/rules/react.js b/rules/react.js index d404b96..850dabf 100644 --- a/rules/react.js +++ b/rules/react.js @@ -19,10 +19,7 @@ module.exports = { 'react/forbid-prop-types': 'error', 'react/no-string-refs': 'error', 'react/jsx-filename-extension': [1, {extensions: ['.js']}], - - // Do not warn or error for destructuring - // See: https://github.com/Expensify/Style-Guide/blob/master/javascript.md#destructuring - 'react/destructuring-assignment': 'off', + 'react/destructuring-assignment': ['error', 'never'], // New versions of react are removing some methods, and those methods have been prefixed with "UNSAFE_" for now. // We need to prevent more usages of these methods and their aliases from being added From 7554ad001065ac605c3f22368457df0eb4eb4adc Mon Sep 17 00:00:00 2001 From: Rory Abraham Date: Fri, 5 Nov 2021 10:34:38 -0700 Subject: [PATCH 2/2] Bump package version to 2.0.18 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 70b26be..99a4c30 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "eslint-config-expensify", - "version": "2.0.16", + "version": "2.0.18", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 9a3a434..c4d07e6 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "eslint-config-expensify", - "version": "2.0.17", + "version": "2.0.18", "description": "Expensify's ESLint configuration following our style guide", "main": "index.js", "repository": {