Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Fix : Android app crushed when use version 6.1.1 #204 #213

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Elanthingal
Copy link

@Elanthingal Elanthingal commented Sep 7, 2024

Text Encoder from text-encoding cause Issue with "The Property 'TextEncoder' is not exist"
. Fixed with the updated text-encoder library

@Elanthingal Elanthingal changed the title Android app crushed when use version 6.1.1 #204 Dependency Fix : Android app crushed when use version 6.1.1 #204 Sep 7, 2024
@Elanthingal
Copy link
Author

@luacmartins / @Kicu - can you please review ?

@Kicu
Copy link
Contributor

Kicu commented Sep 10, 2024

@Elanthingal hey, thanks for contributing.

I will take a look at fast-text-encoding package and will review this PR tomorrow.

@Kicu
Copy link
Contributor

Kicu commented Sep 11, 2024

hey @Elanthingal
I have a few additional questions to better understand what this actually fixes.

We have recently added an Example app, in the /Example directory which allows us to test and develop react-native-qrcode-svg in isolation.
I can see that when building this Example on version 6.3.2 (newest release) for all 3 apps: web, ios, android - they work correctly and I get no errors.

Is it possible for you to switch to using version 6.3.2? and if there are still errors there can you provide an example reproduction for errors?

I can see that text-encoding is not supported anymore (although perhaps it still works), whereas fast-text-encoding is supported, so the library is probably fine. However we shouldn't be updating a dependency without understanding what exactly it fixes and when an old version doesn't work.

For future reference

This PR: #200 introduced this package: https://www.npmjs.com/package/text-encoding - it is archived
https://www.npmjs.com/package/fast-text-encoding - this one looks active

@Elanthingal
Copy link
Author

Elanthingal commented Sep 13, 2024

@Kicu for taking time to review.I will comeback tried with expo. it is working, but i will check how feasible it is to migrate the versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants