Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to icees-kg EPC and predicates #22

Open
karafecho opened this issue Sep 25, 2023 · 3 comments
Open

Updates to icees-kg EPC and predicates #22

karafecho opened this issue Sep 25, 2023 · 3 comments
Assignees

Comments

@karafecho
Copy link

This issue is to follow up on the following updates to icees-kg, marked for completion after the September release.

  1. Delete current biolink:supporting_data_source attribute block from edges
  2. Add biolink:has_supporting_study_result attribute to analysis blocks, following COHD’s example:
  1. Add back RWE edge, but keep the correlated_with, positively_correlated_with, and negatively_correlated_with edges.
@karafecho
Copy link
Author

@maximusunc : As long as we're planning to change the Biolink type to biolink:has_supporting_study_result, can we change the title of our wiki page from https://github.com/NCATSTranslator/Translator-All/wiki/Exposures-Provider-ICEES to https://github.com/NCATSTranslator/Translator-All/wiki/ICEES? I can change the title itself and create a ticket to change the URL in the infores catalog, but you will need to change the URL on icees-kg edges. Does this seem reasonable?

@maximusunc
Copy link
Contributor

Yep, that's fine!

@karafecho
Copy link
Author

Decision, 10.18.2023:

  1. Max will change biolink:supporting_data_source to biolink:has_supporting_study_result.
  2. Max will change the URL from https://github.com/NCATSTranslator/Translator-All/wiki/Exposures-Provider-ICEES to https://github.com/NCATSTranslator/Translator-All/wiki/ICEES.
  3. Kara will then change title of wiki page.

Hold off on listing multiple URLs for supporting study results until after a decision is made regarding whether TRAPI will support the ability to include lists as supporting study results.

Hold off on adding knowledge level (KL) type to edges until after a decision is made regarding whether / when the EPC WG will move forward with proper approach for exposing KL type, which is to have KPs provide this information as part of the TRAPI message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants