Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain Sounds can play at the same time, certain can't? #145

Open
JeremiahGelb opened this issue Oct 23, 2020 · 1 comment
Open

Certain Sounds can play at the same time, certain can't? #145

JeremiahGelb opened this issue Oct 23, 2020 · 1 comment
Labels
Help Wanted Priority: Low Status: Accepted Type: Bug

Comments

@JeremiahGelb
Copy link

EG:

Like A + B doesn’t work
but D + B works
AND A + space works
but D + space does not work

I'm trying to jam here :)
@Externalizable
Copy link
Owner

The original code intentionally prevents simultaneous use of the same paw. See:

bongo.cat/js/core.js

Line 190 in a94ea40

if (jQuery.inArray(commonKey, pressed) !== -1) {

However, this messes with the mouth because it has the same priority as the right paw. See:

bongo.cat/js/core.js

Line 26 in a94ea40

" ": 0,

If anyone wants to submit a Pull Request to allow for InstrumentEnum.MEOW use at all times, be my guest! Otherwise I'll get around to it eventually.

gstone271 added a commit to gstone271/bongo.cat that referenced this issue Nov 12, 2020
@gstone271
Allow any combination of simultaneous sounds
c02ef44 
Remove the check preventing you from using the "same paw" simultaneously.
There's no particular reason the cat should be allowed to play keyboard 2 and marimba Q at the same time (both are left paw), but not be allowed to play keyboard 1 and marimba Q at the same time. This is especially silly with keyboard 1 and bongo A, which are displayed as different paws, but not allowed to be played simultaneously. This behavior is confusing and unnecessary. Remove this rule so you can play whatever you want.
This also fixes issue Externalizable#145.
This change has the side effect of letting you play the bongos very fast by using the keyboard and mouse, but that's fine imo.
@gstone271 gstone271 mentioned this issue Nov 12, 2020
Open
@DeannaGelbart DeannaGelbart mentioned this issue May 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Priority: Low Status: Accepted Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeremiahGelb @Externalizable