Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect image type from buffer #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StevenThuriot
Copy link

As discussed in #87 .
Please let me know if you feel like some parts need improvement. I'll be happy to make the needed adjustments.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.16%) when pulling d350eda on StevenThuriot:master into d5602e3 on EyalAr:master.

@EyalAr
Copy link
Owner

EyalAr commented Dec 28, 2014

@StevenThuriot thanks!
I'm currently travelling; I'll give it a thorough look when I get back in a few days.

@EyalAr
Copy link
Owner

EyalAr commented Jan 25, 2015

@StevenThuriot Haven't forgotten about this PR, just have been a bit busy recently. Hope I can take a look this week.

@StevenThuriot
Copy link
Author

No problem, take your time ☺️

@MAMISHO
Copy link

MAMISHO commented Jul 8, 2016

Some times the images has wrong extension because the users or systems
change the extension when some application can’t open the image. So I
add code to solve that problems. For example, one image can to finish
with .jpg but the image encode is png, now the library throw an error
because just reviews the extension and not the encode. To solve I had
used image-type lib and some modifications on the code of obtain.js

I can't to send my changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants