Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new dialogs in the Call/Calling page #57

Open
jordibc opened this issue Aug 25, 2017 · 2 comments
Open

Use new dialogs in the Call/Calling page #57

jordibc opened this issue Aug 25, 2017 · 2 comments

Comments

@jordibc
Copy link
Contributor

jordibc commented Aug 25, 2017

Instead of the hand-made alerts that the Call and Calling pages use to notify about errors, use these:
https://github.com/EyeSeeTea/FIRE-WiFiCalling/wiki/Dialogs

@jordibc
Copy link
Contributor Author

jordibc commented Aug 28, 2017

Nah, it seems they are not ready to show error messages yet. See comments in https://github.com/EyeSeeTea/FIRE-WiFiCalling/wiki/Dialogs

@jordibc jordibc added in progress and removed ready labels Aug 28, 2017
@MurhafSousli
Copy link
Contributor

@jordibc

Question (Jordi): is this up-to-date? It seems that instead of importing DialogComponent from ../shared/fire-dialog one has to import DialogComponent from ../../shared/dialog/dialog, at least that is currently the case in the development branch.

Right, you have to locate the DialogComponent according to your component location.

Another question (Jordi): it seems that there are no dialogs ready to show the errors as they appear in here for example: https://marvelapp.com/1d00fg0/screen/18291072

We have discussed this earlier and decided to use the DialogComponent for error messages too. so that error message you pointed in the MarvelApp will not be used.

@ifoche ifoche added ready and removed in progress labels Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants