Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$Time$ segments are not handled #56

Closed
bwallberg opened this issue Feb 15, 2024 · 0 comments · Fixed by #61
Closed

$Time$ segments are not handled #56

bwallberg opened this issue Feb 15, 2024 · 0 comments · Fixed by #61
Assignees
@zapfire88
Labels
bug Something isn't working In sprint

Comments

@bwallberg
Copy link
Contributor

If you try to play streams with $Time segments it fails eg. http://localhost:8000/api/v2/manifests/dash/proxy-master.mpd?url=https://livesim.dashif.org/livesim2/segtimeline_1/testpic4_8s/Manifest.mpd
@bwallberg bwallberg added the bug Something isn't working label Feb 15, 2024
bwallberg added a commit that referenced this issue Feb 16, 2024
@bwallberg
fix(#56): $Time$ segments not replaced
56f0681
birme pushed a commit that referenced this issue Feb 16, 2024
@bwallberg
fix(#56): $Time$ segments not replaced (#57)
d894523
@birme birme linked a pull request Feb 22, 2024 that will close this issue
fix(#56): update variable handling #61
Merged
@birme birme closed this as completed in #61 Feb 22, 2024
birme pushed a commit that referenced this issue Feb 22, 2024
@zapfire88 @bwallberg
fix(#56): update variable handling (#61)
2185e69 
* fix: both  and  could be present, causing issues in proxy-manifest build

* chore: reverted ProxyBasenames

* fix: replaces dash with forward slash in url

* chore: add failing unit-test

* wip: variable handling

* fix: handling underscore

* chore: addressed PR comment

---------

Co-authored-by: Benjamin Wallberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zapfire88 zapfire88

Labels
bug Something isn't working In sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#56): update variable handling Eyevinn/chaos-stream-proxy
3 participants
@bwallberg @birme @zapfire88