Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement suggestion for CI/CD scripts #68

Open
yaruno opened this issue Nov 20, 2023 · 1 comment
Open

Improvement suggestion for CI/CD scripts #68

yaruno opened this issue Nov 20, 2023 · 1 comment

Comments

@yaruno
Copy link
Contributor

yaruno commented Nov 20, 2023

To counter introducing regressions in future via pull requests I recommend to modify test running script nodejs.yml to include trigger that runs tests against pull requests when they are introduced.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

Currently:

name: Node CI
  
on: [push]

jobs:
@@@rest of the script@@@

Suggestion:

name: Node CI
on:
  push:
  pull_request:

jobs:
@@@rest of the script@@@
@birme
Copy link
Contributor

birme commented Nov 20, 2023

I concur! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants