New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax of bearer token is incorrect #128

Open

jech opened this issue Jul 10, 2023 · 1 comment

jech commented Jul 10, 2023

Section 4.5 of draft-ietf-wish-whip-08 says:

WHIP endpoints and resources MAY require the HTTP request to be authenticated using an HTTP Authorization header field with a Bearer token as specified in [RFC6750] section 2.1.

Section 2.1 of RFC 6750 specifies the syntax as:

credentials = "Bearer" 1*SP b64token

So lines 8 and 18 of WhipProtocol.ts should say

                "Authorization": "Bearer " + authKey

The text was updated successfully, but these errors were encountered:

Contributor

birme commented Jul 11, 2023

Thanks! You are absolutely correct. We will address this after the summer break unless anyone else wants to provide a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment