Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP request error handling #130

Open
friday opened this issue Dec 7, 2023 · 0 comments
Open

HTTP request error handling #130

friday opened this issue Dec 7, 2023 · 0 comments

Comments

@friday
Copy link
Member

friday commented Dec 7, 2023

On the demo package ingest page (ex https://web.whip.eyevinn.technology/) we are not showing any error message if the connection fails. Some ad blockers (like Brave browsers defaults) are blocking cross-site requests to localhost/and or 127.0.0.1 etc from other domains even if the browser actually allows them without CORS issues.

Maybe it would be better to be able to handle/catch these as WHIPClient events, and use that from the demo page to show some modal?

They are thrown from

return fetch(url, {

Possibly related to #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant