Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending new line in chat creates multiple messages #1036

Open
Geosearchef opened this issue May 18, 2018 · 5 comments
Open

Sending new line in chat creates multiple messages #1036

Geosearchef opened this issue May 18, 2018 · 5 comments

Comments

@Geosearchef
Copy link
Member

When sending a chat message containing multiple lines (e.g. from copy pasting) the client just decomposes it in to multiple messages, which get's extremly annoying on the receiving side as it creates countless notifications that stack up.

Would suggest just disallowing multiple lines in the chat at once.

@Wesmania
Copy link
Contributor

I can reproduce the issue, I'll see about fixing it.

@Wesmania
Copy link
Contributor

Wesmania commented May 19, 2018

Okay, I can see that there is a related bug in the develop client that both collapses newlines and sends the message multiple times. As for this one - maybe we can just make a notification timeout instead? Which notifications do you have in mind?

@Geosearchef
Copy link
Member Author

I'm a java client dev and tried to prohibit a notification spam (it fills your left screen with stacked notifications). I can't think of a way to do this as for multiple messages, you want to throw multiple notifications.

The java client just sends new lines as spaces which isn't the right solution in my opinion, as sending multiple lines can be quite useful. Is there a way we can send multiple lines per message? Shouldn't pose a problem for IRC, does it?

@Wesmania
Copy link
Contributor

https://tools.ietf.org/html/rfc1459#section-2.3.1 claims that messages cannot contain CR or LF except for CRLF at the end, so there's no other way, I'm afraid.
Maybe you can add a tiny timeout (like 0.5 second) to notifications, so you only report the first of multiple messages in quick succession? It's very unlikely somebody would type messages that fast unless they're spamming something anyway.

@Wesmania
Copy link
Contributor

Adding to the above - sending multiple messages when given a multi-line input seems to have been intended behaviour, it's also present in the 0.16.1 chat implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants