Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache news tab #2554

Closed
BlackYps opened this issue Jan 30, 2022 · 3 comments
Closed

Cache news tab #2554

BlackYps opened this issue Jan 30, 2022 · 3 comments
Labels

Comments

@BlackYps
Copy link
Collaborator

When I originally coded the new news website into the client we decided to reload the website everytime the tab is visited instead of never, to accomodate the use case where people keep the client open for days.
It is now clear that this wasn't a really good decision. Given that the news site basically never gets updated more than once a day we should just reload it after some hours. This way everyone still stays up to date and we get rid of the considerable loading time for 99% of the people.

@BlackYps
Copy link
Collaborator Author

Can I get some context please?

@Sheikah45
Copy link
Member

Sheikah45 commented Nov 27, 2023

In #3050 I am removing effectively all caching of controllers as it lead to memory leaks and other transient errors. It also encouraged state and business logic to be put into the UI controllers which is not really maintainable.

And this caching of controllers didn't even really speed things up vs just ensuring that heavy IO operations are not done on the application thread.

So caching of the news tab would require caching the controller which we are moving away from.

@BlackYps
Copy link
Collaborator Author

I see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants