Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /division arg not being valid and division image filename format #6581

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Dec 12, 2024

Issue

#6160 broke #4263 because it wanted to add a space to display the division better in text format in the score board, but the original #4263 was meant for the file names, for example goldIV_medium.png.

The /division arg was also not valid.

Description of the proposed changes

  • Change the file name format to match the displayed text format.
  • Fix the typo making /division and invalid command line arg.
  • Assign divisions correctly in the launch script.

Testing done on the proposed changes

Launched a few games with the script and tested to see if the mod "4z0t's ScoreBoard" showed divisions properly when the "Show divisions instead of rating" setting was enabled. Made sure to check that grandmaster and unlisted worked with the mod as well.
The division arg format seems to match what is expected to be sent by the client and indirectly the server.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added type: bug area: ui Anything to do with the User Interface of the Game area: matchmaker/autolobby related to the matchmaker lobby labels Dec 12, 2024
@lL1l1 lL1l1 added this to the Development I of 2025 milestone Dec 12, 2024
@lL1l1 lL1l1 marked this pull request as ready for review December 12, 2024 06:48
@lL1l1 lL1l1 requested a review from Garanas December 12, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: matchmaker/autolobby related to the matchmaker lobby area: ui Anything to do with the User Interface of the Game type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant