Fix /division
arg not being valid and division image filename format
#6581
+44
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#6160 broke #4263 because it wanted to add a space to display the division better in text format in the score board, but the original #4263 was meant for the file names, for example
goldIV_medium.png
.The
/division
arg was also not valid.Description of the proposed changes
/division
and invalid command line arg.Testing done on the proposed changes
Launched a few games with the script and tested to see if the mod "4z0t's ScoreBoard" showed divisions properly when the "Show divisions instead of rating" setting was enabled. Made sure to check that grandmaster and unlisted worked with the mod as well.
The division arg format seems to match what is expected to be sent by the client and indirectly the server.
Checklist