[ Linux ] Mods installed from vault create a secondary flattened directory structure

[douglasg14b]

When a mod is installed from the vault, that mod is put int the Mods directory as you would expect, but the entire directory structure of that mod will also be flattened into the Mods folder with the full path of the structure being the name of the folder. Creating a huge mess of empty folders.

This also causes the client to show that mods are corrupt for every one of these folders in the notifications.

Example:

[tatsujb]

still happens for some maps.

[1-alex98]

That's because \ is for windows and / is for unix i guess

[1-alex98]

Can u pls check if that is the case in the version > v1.0.0 and in old versions, we indeed changed code between that versions

[1-alex98]

oh this issue is damn old i thought it was new

[tatsujb]

hmm maybe it's fixed.
only mod I could still reproduce it for was quality of performance but now it's not in the vault anymore.
(better off)

[tatsujb]

nope. people still have this mod and host games with it and when you join it still does this :
+"TheDairyFarm" whatever that is :

[Slothologist]

It seems this is actually not a bug of the client, but an issue with the zip files/ mods themselves. Upon inspection, https://content.faforever.com/mods/the_dairy_farm.v0005.zip which is downloaded when installing this mod, always contains these weird folders, regardless of the archive manager used on linux. This is not the case for other mods, such as https://content.faforever.com/mods/supreme_score_board.v0002.zip
Could a Windows user confirm whether or not those weird folders are created/included in the archive on your OS as well? It might just be that Windows does not unzip these folders or ignores them for whatever reason. Or that Linux has some problem with these specific archives.
You will also note that TheDairyfarm gets correctly installed, and can be played. I would suspect the same for Quality of performance (but cannot test that atm).

[1-alex98]

Really old mods were packed by the py client, but since a long time that is the job of the java client. So it might be that the time difference between the both make some mods linux compatible and others not.

[1-alex98]

No flat directory structure on windows, so probabaly / vs \

[1-alex98]

Also we could try to hack in that it works for both OSES but this then is a java-commons issue

[1-alex98]

The directory split is / on windows on linux it is a valid directoy character so this might explain it.

[1-alex98]

Hmm so the queston might also be what causes this mal packaged zips. Seems to be an issue that exists for a long time. Maybe u can find out if it happens especially for mods uploaded a long time ago or also newer mods

[1-alex98]

if u let me guess it happens for mod uploaded by load ways