Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove one of the player info's sent on login #901

Open
Askaholic opened this issue Apr 18, 2022 · 0 comments
Open

Remove one of the player info's sent on login #901

Askaholic opened this issue Apr 18, 2022 · 0 comments
Labels
proposal A feature or change that is up for discussion

Comments

@Askaholic
Copy link
Collaborator

When a player logs in they get their own player_info sent to them 3 times.

  1. In the welcome message
  2. In the player list
  3. In the broadcasted player list that is triggered by the login event happening

At least one of these could be removed since it's just a waste of bandwidth, and would also eliminate a redundant player update on the client side.

Probably the best thing to do would be to filter out the player from the player list sent in (2).

This is a pretty minor improvement.

@Askaholic Askaholic added the proposal A feature or change that is up for discussion label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A feature or change that is up for discussion
Projects
None yet
Development

No branches or pull requests

1 participant