Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy implementation for client command match_ready (#607) #820

Merged

Conversation

Katharsas
Copy link
Contributor

@Katharsas Katharsas commented Aug 8, 2021

Moves #607 forward (see FAForever/downlords-faf-client#1783 (comment)).

Sadly untested because if currently don't have a local environment for running the python server, so i would be glad if somebody else could test that. Sorry.

@Katharsas Katharsas force-pushed the feature/#607-match-confirmation-dummy branch from 2519b86 to ba0e6c9 Compare August 8, 2021 20:11
@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #820 (80978f3) into develop (b977205) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
server/lobbyconnection.py 94.22% <100.00%> (+0.01%) ⬆️
server/timing/timer.py 77.77% <0.00%> (-1.59%) ⬇️

@Askaholic
Copy link
Collaborator

Can you also add a unit test to unit_tests/test_lobbyconnection.py? It doesn’t need to do much just trigger the command to make sure it doesn’t raise any exceptions (see other examples in that file)

@Katharsas
Copy link
Contributor Author

Of couse, this shall present no problem for me!

@Katharsas Katharsas requested a review from Askaholic August 9, 2021 20:33
@Askaholic Askaholic merged commit 9955891 into FAForever:develop Aug 9, 2021
@Katharsas Katharsas deleted the feature/#607-match-confirmation-dummy branch August 9, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants