Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Form::domain functions consistent #3598

Open
jpdean opened this issue Jan 13, 2025 · 0 comments
Open

Make Form::domain functions consistent #3598

jpdean opened this issue Jan 13, 2025 · 0 comments
Milestone

Comments

@jpdean
Copy link
Member

jpdean commented Jan 13, 2025

As pointed out by @jorgensd, currently there are some inconsistencies in the Form::domain functions. One simply returns a span, whilst the other does some computation (to map entities from one mesh to another) and returns a vector. Since all the data computed on is immutable, we should probably compute it once in Form's constructor and store it. Then, both domain functions can return a span and we avoid unnecessary computation.

@garth-wells garth-wells added this to the 0.10.0 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants