You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As pointed out by @jorgensd, currently there are some inconsistencies in the Form::domain functions. One simply returns a span, whilst the other does some computation (to map entities from one mesh to another) and returns a vector. Since all the data computed on is immutable, we should probably compute it once in Form's constructor and store it. Then, both domain functions can return a span and we avoid unnecessary computation.
The text was updated successfully, but these errors were encountered:
As pointed out by @jorgensd, currently there are some inconsistencies in the
Form::domain
functions. One simply returns aspan
, whilst the other does some computation (to map entities from one mesh to another) and returns avector
. Since all the data computed on is immutable, we should probably compute it once inForm
's constructor and store it. Then, bothdomain
functions can return aspan
and we avoid unnecessary computation.The text was updated successfully, but these errors were encountered: