SUSHI constrains too much when type constraining to a choice of resource and a profile of that resource

[cmoesel]

Given:

* identifier only Identifier or MyIdentifier

SUSHI produces the type:

"type": [
  {
    "code": "Identifier",
    "profile": [
      "http://example.org/StructureDefinition/MyIdentifier"
    ]
  }
],

FSH Online Link

This is incorrect because any Identifier should be allowed, but the constraint SUSHI outputs requires instances to conform to MyIdentifier profile.

The correct behavior should be either a no-op (because the adding the profile to the choice is meaningless since all Identifiers are allowed) or should list the canonical for the resource in the profile array (which more closely aligns with what the user asked for):

"type": [
  {
    "code": "Identifier",
    "profile": [
      "http://hl7.org/fhir/StructureDefinition/Identifier",
      "http://example.org/StructureDefinition/MyIdentifier"
    ]
  }
],

See: #shorthand > Issue specifying two types, one not rendered @ 💬

[Teruk15]

Hello, @cmoesel may I work on this?

[cmoesel]

Hi @Teruk15. Yes, absolutely! See the SUSHI README Developer Instructions for core information about SUSHI development. We also have files on contributing, best practices, and code of conduct in the root of the repository.

Thanks for offering to help. I look forward to you PR. Let me know if you run into any issues. I marked this as a "good first issue" based on my recollection of the code -- but it's always possible that it might turn out more complicated than expected.