Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceMacroProperty AtomicAdd and AtomicSub #1203

Open
mondus opened this issue May 7, 2024 · 1 comment
Open

DeviceMacroProperty AtomicAdd and AtomicSub #1203

mondus opened this issue May 7, 2024 · 1 comment

Comments

@mondus
Copy link
Member

mondus commented May 7, 2024

DeviceMacroProperty has operator overloading for + and - which is incorrect within the API docs as it suggests that this atomically modifies the value (it does not). We should add support for atomic add and sub (sub should use add but negate the value to avoid type restrictions). Both should have return values. We should also update the API docs so they are correct and update the user docs to make it clear which operators modify the value (i.e. -= and += are atomic).

@Robadob
Copy link
Member

Robadob commented May 7, 2024

userguide will want add, sub added to the table of misc. atomic functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants