Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No branch protection on master #165

Open
yoe opened this issue Jan 30, 2019 · 1 comment
Open

No branch protection on master #165

yoe opened this issue Jan 30, 2019 · 1 comment

Comments

@yoe
Copy link
Member

yoe commented Jan 30, 2019

Someone set up the "review required" bit on this repository, on the master branch, less than a week before the conference.

This is not the time to be making such changes. We can discuss at the postmortem if that's necessary, but we do not block people from working by changing the whole workflow that short of a time before the conference.

It has been switched off again now. Please leave it like that until after the conference.

@krokodilerian
Copy link
Contributor

Let me back @yoe here. I say we're grown up people and we know not to make breaking changes in the last moment, and also that we might need to push something during FOSDEM because of $crap. So blocking isn't a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants