-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP ETag #235
Comments
For the record, you should be able to use HTTP If-Modified-Since with the date returned by the last-modified header to achieve the same effect as ETag: skip downloading the content if it hasn't changed. |
+ Add "schedule_last_modified" column to "meta" table. + Docs: + https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching + https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since + Related: + FOSDEM/website#235 + https://git.cccv.de/hub/hub/-/issues/564
+ Add "schedule_last_modified" column to "meta" table. + Docs: + https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching + https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since + Related: + FOSDEM/website#235 + https://git.cccv.de/hub/hub/-/issues/564
@cbeyls Thank you for the heads up! 👍 I wasn't aware that the app does not make use of this header. I have now implemented it. |
+ Add "schedule_last_modified" column to "meta" table. Increase "meta" database version. + Ensure default value is empty string. Otherwise, the app would crash on the next update in RealMetaDatabaseRepository/query/getString with a NPE. + Docs: + https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching + https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since + Related: + FOSDEM/website#235 + https://git.cccv.de/hub/hub/-/issues/564
@gerryd - you added etag off previously (April 2019).
Any reason I'm not aware of not to enable it again? |
+ Add "schedule_last_modified" column to "meta" table. Increase "meta" database version. + Ensure default value is empty string. Otherwise, the app would crash on the next update in RealMetaDatabaseRepository/query/getString with a NPE. + Docs: + https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching + https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since + Related: + FOSDEM/website#235 + https://git.cccv.de/hub/hub/-/issues/564
Good question. I'm not entirely sure, but I think I remember there were issues with the CSS sprites and caching. |
+ Add "schedule_last_modified" column to "meta" table. Increase "meta" database version. + Ensure default value is empty string. Otherwise, the app would crash on the next update in RealMetaDatabaseRepository/query/getString with a NPE. + Docs: + https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching + https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since + Related: + FOSDEM/website#235 + https://git.cccv.de/hub/hub/-/issues/564
Context
The provided
schedule.xml
is fetched by the FOSDEM Schedule app for Android to render the conference program in the mobile app.To avoid unneeded downloads of the schedule when unchanged the app reads the HTTP ETag of the response and adds it to each subsequent request. If the schedule has not changed a server supporting HTTP ETag would respond with an
HTTP 304 NOT MODIFIED
status code and an empty response payload.Also, schedule update announcements are presented to the user of the app. These should not be shown when the schedule has not changed.
Current state
The server seems not to support HTTP ETag for the given URL:
Request
Can you please add support for HTTP ETag to the webserver before/during/after the conference? I am mentioning all time frames because some conferences tend to archive their schedule as a static resource which then no longer supports HTTP ETag.
The text was updated successfully, but these errors were encountered: