Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Fabric and Tile description #149

Closed
mole99 opened this issue Feb 5, 2024 · 1 comment · Fixed by #154
Closed

Separate Fabric and Tile description #149

mole99 opened this issue Feb 5, 2024 · 1 comment · Fixed by #154

Comments

@mole99
Copy link
Contributor

mole99 commented Feb 5, 2024

I think it would be clearer and more convenient to separate the fabric and tile descriptions in fabric.csv.

The file fabric.csv would then only contain the fabric description. The tile descriptions would reside in the tile-specific subfolders as e.g. tile.csv.

This makes sense as the tile configurations could be used for several fabrics and do not need to be duplicated.

@mole99 mole99 mentioned this issue Feb 5, 2024
@KelvinChung2000
Copy link
Collaborator

A way to do this is to create a new attribute in the fabric.csv, which links to the tile.csv information. This should be straightforward.

You might consider allowing another file format for the configuration data, i.e. JSON, TOML or XML since libraries are already available for parsing them into dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants