Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think this is the problem we were seeing on Tuesday #66

Open
DavidDePauw1 opened this issue Mar 14, 2024 · 0 comments
Open

I think this is the problem we were seeing on Tuesday #66

DavidDePauw1 opened this issue Mar 14, 2024 · 0 comments

Comments

@DavidDePauw1
Copy link

@nab138 Did you intend to make this a race group? Race groups cancel all commands when any single one of them finishes. I believe this explains what we saw on Tuesday: The robot was already within the shooting zone, satisfying it's finish condition, and canceling the whole group prior to spinup or transit doing anything at all.

I believe a better strategy would be to do the first three conditions here in parallel (move to zone, aim shooter, spinup wheels), and only move on to the shoot command once all three have competed. I'm positive WPI lib has a group that does something like "continue until all finish", just not sure what it's called off the top of my head (I think it might just be the normal Parallel group?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant