Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Review locking of static hooks #342

Open
michaelmss opened this issue Apr 5, 2022 · 2 comments
Open

Review locking of static hooks #342

michaelmss opened this issue Apr 5, 2022 · 2 comments
Assignees
@KaneBarnes @ACat701
Labels
low priority Issues that don't need to be addressed immediately

Comments

@michaelmss
Copy link

As of #341 we are locking the static hooks in teleopinit and autonomousinit - we may want to look into doing this elsewhere to maintain our current workflow (potentially constructor of robotcontainer, which gets called in robotinit)
@michaelmss michaelmss added the low priority Issues that don't need to be addressed immediately label Apr 5, 2022
@TaylerUva
Copy link
Member

just be careful that this is called in both teleop init and autonomous init. If its just robotinit it would only make that change on boot.

@michaelmss
Copy link
Author

michaelmss commented Apr 6, 2022 •
edited
Loading

ah right good point! Perhaps we could just create a method in robotcontainer so that the climber subsystem can remain private then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KaneBarnes KaneBarnes

@ACat701 ACat701

Labels
low priority Issues that don't need to be addressed immediately
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TaylerUva @michaelmss @KaneBarnes @ACat701