-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: Fix for match source-protocol in route-map for redistribute cmd #17362
Merged
ton31337
merged 1 commit into
FRRouting:master
from
raja-rajasekar:rajasekarr/src_proto_for_redist_cmd
Nov 9, 2024
Merged
bgpd: Fix for match source-protocol in route-map for redistribute cmd #17362
ton31337
merged 1 commit into
FRRouting:master
from
raja-rajasekar:rajasekarr/src_proto_for_redist_cmd
Nov 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Topotest run for newly introduced test
|
ton31337
reviewed
Nov 6, 2024
tests/topotests/bgp_route_map_match_source_protocol/test_bgp_route_map_match_source_protocol.py
Show resolved
Hide resolved
raja-rajasekar
force-pushed
the
rajasekarr/src_proto_for_redist_cmd
branch
2 times, most recently
from
November 8, 2024 07:25
af46397
to
c06b291
Compare
ton31337
reviewed
Nov 8, 2024
tests/topotests/bgp_route_map_match_source_protocol/test_bgp_route_map_match_source_protocol.py
Outdated
Show resolved
Hide resolved
ton31337
reviewed
Nov 8, 2024
tests/topotests/bgp_route_map_match_source_protocol/test_bgp_route_map_match_source_protocol.py
Outdated
Show resolved
Hide resolved
raja-rajasekar
force-pushed
the
rajasekarr/src_proto_for_redist_cmd
branch
2 times, most recently
from
November 8, 2024 07:44
7f3f6d2
to
db02301
Compare
@Mergifyio backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
Could you fix frrbot formatting before merging? |
A redistribute cmd can have a route-map attached to it and adding the match source-protocol to that route-map means BGP to filter which protocol routes to accept among the bunch of routes zebra is sending. Fixing this since this wasnt implemented earlier. Ticket :#4119692 Signed-off-by: Donald Sharp <[email protected]> Signed-off-by: Rajasekar Raja <[email protected]>
raja-rajasekar
force-pushed
the
rajasekarr/src_proto_for_redist_cmd
branch
from
November 9, 2024 16:37
db02301
to
68358c0
Compare
Done |
This was referenced Nov 9, 2024
Merged
Closed
Closed
Closed
ton31337
added a commit
that referenced
this pull request
Nov 10, 2024
bgpd: Fix for match source-protocol in route-map for redistribute cmd (backport #17362)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A redistribute cmd can have a route-map attached to it and adding the match source-protocol to that route-map means BGP to filter which protocol routes to accept among the bunch of routes zebra is sending.
Fixing this since this wasnt implemented earlier.
Ticket :#4119692