Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Fix for match source-protocol in route-map for redistribute cmd #17362

Conversation

raja-rajasekar
Copy link
Contributor

A redistribute cmd can have a route-map attached to it and adding the match source-protocol to that route-map means BGP to filter which protocol routes to accept among the bunch of routes zebra is sending.

Fixing this since this wasnt implemented earlier.

Ticket :#4119692

@raja-rajasekar
Copy link
Contributor Author

Topotest run for newly introduced test

rajasekarr@rajasekarr:~/upstream/frr/tests/topotests/bgp_route_map_match_source_protocol$ sudo -E python3 -m pytest
=============================================== test session starts ================================================
platform linux -- Python 3.10.12, pytest-8.3.3, pluggy-1.5.0
rootdir: /home/rajasekarr/upstream/frr/tests/topotests
configfile: pytest.ini
plugins: xdist-3.6.1
collected 1 item                                                                                                   

test_bgp_route_map_match_source_protocol.py .                                                                [100%]

================================================= warnings summary =================================================
../../../../../../../usr/local/lib/python3.10/dist-packages/_pytest/config/__init__.py:1441
  /usr/local/lib/python3.10/dist-packages/_pytest/config/__init__.py:1441: PytestConfigWarning: Unknown config option: asyncio_default_fixture_loop_scope
  
    self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")

../../../../../../../usr/local/lib/python3.10/dist-packages/_pytest/config/__init__.py:1441
  /usr/local/lib/python3.10/dist-packages/_pytest/config/__init__.py:1441: PytestConfigWarning: Unknown config option: asyncio_mode
  
    self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
--------------------------------- generated xml file: /tmp/topotests/topotests.xml ---------------------------------
========================================== 1 passed, 2 warnings in 8.62s ===========================================

@ton31337
Copy link
Member

ton31337 commented Nov 7, 2024

@raja-rajasekar raja-rajasekar force-pushed the rajasekarr/src_proto_for_redist_cmd branch 2 times, most recently from af46397 to c06b291 Compare November 8, 2024 07:25
@raja-rajasekar raja-rajasekar force-pushed the rajasekarr/src_proto_for_redist_cmd branch 2 times, most recently from 7f3f6d2 to db02301 Compare November 8, 2024 07:44
@ton31337
Copy link
Member

ton31337 commented Nov 9, 2024

@Mergifyio backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

Copy link

mergify bot commented Nov 9, 2024

backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

✅ Backports have been created

@ton31337
Copy link
Member

ton31337 commented Nov 9, 2024

Could you fix frrbot formatting before merging?

A redistribute cmd can have a route-map attached to it and adding the
match source-protocol to that route-map means BGP to filter which
protocol routes to accept among the bunch of routes zebra is sending.

Fixing this since this wasnt implemented earlier.

Ticket :#4119692

Signed-off-by: Donald Sharp <[email protected]>

Signed-off-by: Rajasekar Raja <[email protected]>
@raja-rajasekar raja-rajasekar force-pushed the rajasekarr/src_proto_for_redist_cmd branch from db02301 to 68358c0 Compare November 9, 2024 16:37
@raja-rajasekar
Copy link
Contributor Author

Could you fix frrbot formatting before merging?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants