Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blade_%s: prefix to geometry variables #21

Open
fzahle opened this issue Mar 1, 2016 · 4 comments
Open

add blade_%s: prefix to geometry variables #21

fzahle opened this issue Mar 1, 2016 · 4 comments
Labels

Comments

@fzahle
Copy link
Member

fzahle commented Mar 1, 2016

The blade planform is defined with the following parameters: ['x', 'y', 'z', 'rot_x', 'rot_y', 'rot_z', 'chord', 'rthick', 'p_le']. In the old OpenMDAO they were nested inside a vartree, making it clear that all these parameters belonged to a planform definition. Now that vartrees no longer exist, the first version we did simply had the parameters added and promoted with the above names. While names like chord are self-explanatory x y z are not. so to be more unambiguous I propose that we start using prefixes for these parameters, so they're referred to as e.g. blade_ae:s and blade_ae:chord. The pf parameters discretized for the structural calculations will then be named blade_st:s and blade_st:chord.

Any objections? @mrosemeier what do you think?

@mrosemeier
Copy link
Collaborator

I have no objections using prefixes. Would that more or less replace the suffixes that are currently added in the components, i.e. suffix='_st'?

@fzahle
Copy link
Member Author

fzahle commented Mar 1, 2016

yes, the suffix in the current version will be become part of the prefix.

fzahle added a commit to fzahle/fusedwind-dev that referenced this issue Mar 2, 2016
@fzahle
Copy link
Member Author

fzahle commented Mar 2, 2016

FYI @tlbl and @pilotmm let me know if you have any comments.

And I won't merge this until we have adapted the other wrappers.

@pilotmm
Copy link

pilotmm commented Mar 2, 2016

I think that change makes a lot of sense...

@fzahle fzahle added the turbine label Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants