Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile #1917

Closed
techsideofficial opened this issue Dec 17, 2024 · 5 comments
Closed

Doesn't compile #1917

techsideofficial opened this issue Dec 17, 2024 · 5 comments

Comments

@techsideofficial
Copy link

Running it through github actions doesn't work (made a workflow on my fork)

Run ./waf.bat configure --sdl2=SDL2
Active code page: [6](https://github.com/ArpaRec/GoldSrc_Xash/actions/runs/12366625488/job/34513613611#step:4:7)5001
Using C:\hostedtoolcache\windows\Python\3.12.8\x64\python.exe
Setting top to                                          : D:\a\GoldSrc_Xash\GoldSrc_Xash 
Setting out to                                          : D:\a\GoldSrc_Xash\GoldSrc_Xash\build 
Build type                                              : humanrights 
LTO build                                               : no 
PolyOpt build                                           : no 
OpenMP build                                            : no 
Generate profile                                        : no 
Use profile                                             : not found 
Checking for 'msvc' (C compiler)                        : C:\Program Files (x[8](https://github.com/ArpaRec/GoldSrc_Xash/actions/runs/12366625488/job/34513613611#step:4:9)6)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.2[9](https://github.com/ArpaRec/GoldSrc_Xash/actions/runs/12366625488/job/34513613611#step:4:10).30133\bin\HostX64\x86\CL.exe 
Target OS                                               : win32 
Target CPU                                              : x86 
Target binfmt                                           : pe 
Checking for 'msvc' (C++ compiler)                      : C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x86\CL.exe 
Target OS                                               : win32 
Target CPU                                              : x86 
Target binfmt                                           : pe 
Checking for program 'cmake'                            : C:\Program Files\CMake\bin\cmake.exe 
Checking for required C flags                           : yes 
Checking for required C++ flags                         : yes 
Checking for MSVC library                               : user32 
Checking for MSVC library                               : shell32 
Checking for MSVC library                               : gdi32 
Checking for MSVC library                               : advapi32 
Checking for MSVC library                               : dbghelp 
Checking for MSVC library                               : psapi 
Checking for MSVC library                               : ws2_32 
Checking for program 'pkg-config'                       : C:\Strawberry\perl\bin\pkg-config.bat 
Checking for 'ogg'                                      : not found 
Checking for 'opusfile'                                 : not found 
Checking for 'vorbis'                                   : not found 
Checking for 'vorbisfile'                               : not found 
Checking for 'opus'                                     : not found 
Checking for library bz2                                : no 
--> public                                              : in progress 
Checking for program 'git'                              : C:\Program Files\Git\bin\git.exe 
Git commit hash                                         : 8540b93 
Git branch                                              : master 
Checking for stdint.h                                   : yes 
Checking for tgmath.h                                   : yes 
<-- public                                              : done 
--> filesystem                                          : in progress 
<-- filesystem                                          : done 
--> 3rdparty/extras                                     : in progress 
<-- 3rdparty/extras                                     : done 
--> ref/gl                                              : in progress 
<-- ref/gl                                              : done 
--> ref/soft                                            : in progress 
<-- ref/soft                                            : done 
--> 3rdparty/bzip2                                      : in progress 
<-- 3rdparty/bzip2                                      : done 
--> 3rdparty/opus                                       : in progress 
Checking for C99 VLA support                            : no 
Checking for alloca in alloca.h header                  : no 
Checking for alloca.h in stdlib.h                       : yes 
<-- 3rdparty/opus                                       : done 
--> 3rdparty/libogg                                     : in progress 
Checking for header inttypes.h                          : yes 
<-- 3rdparty/libogg                                     : done 
--> 3rdparty/vorbis                                     : in progress 
Checking for memory.h header                            : yes 
Checking for alloca in alloca.h header                  : no 
<-- 3rdparty/vorbis                                     : done 
--> 3rdparty/opusfile                                   : in progress 
<-- 3rdparty/opusfile                                   : done 
--> 3rdparty/mainui                                     : in progress 
Checking if 'msvc' supports C++[11](https://github.com/ArpaRec/GoldSrc_Xash/actions/runs/12366625488/job/34513613611#step:4:12)                       : yes 
<-- 3rdparty/mainui                                     : done 
--> 3rdparty/vgui_support                               : in progress 
Does this architecture support VGUI?                    : yes 
Does this OS support VGUI?                              : yes 
Does this toolchain able to link VGUI?                  : yes 
Configuring VGUI by provided path                       : yes: ['vgui'], ['D:\\a\\GoldSrc_Xash\\GoldSrc_Xash\\3rdparty\\vgui_support\\vgui-dev\\lib\\win32_vc6'], ['D:\\a\\GoldSrc_Xash\\GoldSrc_Xash\\3rdparty\\vgui_support\\vgui-dev\\include'] 
Checking for library VGUI sanity                        : no 
Can't compile simple program. Check your path to vgui-dev repository.
(complete log in D:\a\GoldSrc_Xash\GoldSrc_Xash\build\config.log)
Active code page: 65001
Using C:\hostedtoolcache\windows\Python\3.[12](https://github.com/ArpaRec/GoldSrc_Xash/actions/runs/12366625488/job/34513613611#step:4:13).8\x64\python.exe
The project was not configured: run "waf configure" first!
Active code page: 65001
Using C:\hostedtoolcache\windows\Python\3.12.8\x64\python.exe
The project was not configured: run "waf configure" first!
Error: Process completed with exit code 1.
@a1batross
Copy link
Member

Can I ask you why do you want to make your own engine build? Especially, after replacing github workflow with one that doesn't work and being surprised by it?

@techsideofficial
Copy link
Author

@a1batross I only want to build for one platform, and that workflow had too much in it for me to easily figure out how to build for only one platform.

@a1batross
Copy link
Member

@techsideofficial then why not just download the specific build from https://github.com/FWGS/xash3d-fwgs/releases/tag/continuous?

@techsideofficial
Copy link
Author

@a1batross I want to build it myself so I can make changes to it for my own use.

@a1batross
Copy link
Member

@techsideofficial almost everything can be done on game code side, you don't need to modify the engine.

Don't get me wrong, the engine itself is in active development and hard forking is not a good strategy, as it will only complicate merging back fixes and new features in the future. There are a multitude of projects based on Xash3D that are stuck with ancient and unsupported versions of the engine.

@a1batross a1batross closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants