Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnchantmentEvents.MODIFY does not synchronize changes with the client unlike in vanilla #4470

Open
maityyy opened this issue Feb 25, 2025 · 1 comment
Open

EnchantmentEvents.MODIFY does not synchronize changes with the client unlike in vanilla #4470

maityyy opened this issue Feb 25, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@maityyy
Copy link
Contributor

maityyy commented Feb 25, 2025

Even though the effects list seems to be entirely server-side (only uses ServerWorld), it still synchronizes with the client if you overwrite it via data pack. EnchantmentEvents.MODIFY on the other hand desynchronizes this list, potentially causing problems.

This problem is similar to #3897 and its fix is exactly the same: cc02f1c
@modmuss50 modmuss50 added the bug Something isn't working label Feb 25, 2025
@varungole
Copy link

Could I fix this? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@modmuss50 @maityyy @varungole