Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lack of partial signature remapping #126

Open
tildejustin opened this issue Mar 8, 2024 · 0 comments
Open

lack of partial signature remapping #126

tildejustin opened this issue Mar 8, 2024 · 0 comments

Comments

@tildejustin
Copy link

In prior versions of loom, or withuseLegacyMixinAp = true, signatures which did not exist in the minecraft version being compiled against could still be written partially with named, partially with intermediary mappings. Example:
https://github.com/RedLime/SleepBackground/blob/31fcebfba49dd36d9edfa2d53981febcbcecaef8/src/main/java/com/redlimerl/sleepbackground/mixin/MixinMinecraftClient.java#L41-L43. With useLegacyMixinAp = false, one has to manually remap the entire signature if it does not exist in the compile target jar, since the named parts of the signature are not remapped (I verified this with vineflower).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant